[OPAL] Bug in SIPConnection::OnReceivedSDPMediaDescription

[Guillaume Fraysse <gfraysse (at) gmail.com>]

Hello everyone,

I've been testing the last release of OPAL that can be found on
voxgratia.org the 2.1 beta2 and I found what seems to be a bug, or at
least introduce a big step back for the way I use it.

I'm using an external RTP stack and it seems that in that piece of
code is the cause of my problem :

SIPConnection::OnReceivedSDPMediaDescription method
  rtpSession = OnUseRTPSession(rtpSessionId, address, localAddress);
  if (rtpSession == NULL) {
      Release(EndedByTransportFail);
      return FALSE;
  }

as well as a similar piece of code in the
SIPConnection::OnSendSDPMediaDescription method.

the OnUseRTPSession returns NULL if the rtp session is not created,
even if it's not because of an error and a volunteer act.
So the call get released...

I'm not sure that's it's something that is wanted.

I made some ugly workaround to simply not release the call and added a
check on the validity of rtpSession around the call to
SetRemoteSocketInfo.

I haven't been able to check if the CVS version works better as of now
the sourceforge CVS web interface is out.

Best regards,
Guillaume
------------------------------------------------------------------------
Check the FAQ before asking! - http://www.openh323.org/~openh323/fom.cgi
The OpenH323 Project mailing list, using Mailman. To unsubscribe or
change your subscription options, goto
http://www.openh323.org/mailman/listinfo/openh323
Maintained by Quicknet Technologies, Inc - http://www.quicknet.net
------------------------------------------------------------------------