[OPAL] Bug in SIPConnection::OnReceivedSDPMediaDescription

[Damien Sandras <dsandras (at) seconix.com>]

Hello,


Le vendredi 03 février 2006 à 11:28 +0100, Guillaume Fraysse a écrit :
> Hello everyone,
> 
> I've been testing the last release of OPAL that can be found on
> voxgratia.org the 2.1 beta2 and I found what seems to be a bug, or at
> least introduce a big step back for the way I use it.
> 
> I'm using an external RTP stack and it seems that in that piece of
> code is the cause of my problem :
> 
> SIPConnection::OnReceivedSDPMediaDescription method
>   rtpSession = OnUseRTPSession(rtpSessionId, address, localAddress);
>   if (rtpSession == NULL) {
>       Release(EndedByTransportFail);
>       return FALSE;
>   }
> 
> as well as a similar piece of code in the
> SIPConnection::OnSendSDPMediaDescription method.
> 
> the OnUseRTPSession returns NULL if the rtp session is not created,
> even if it's not because of an error and a volunteer act.
> So the call get released...
> 
> I'm not sure that's it's something that is wanted.
> 

Yes it is wanted. I do not know what the mechanism is to use an external
RTP channel though. However, it seems normal that if OnUseRTPSession
doesn't return a session, we can not continue. 

> I made some ugly workaround to simply not release the call and added a
> check on the validity of rtpSession around the call to
> SetRemoteSocketInfo.
> 
> I haven't been able to check if the CVS version works better as of now
> the sourceforge CVS web interface is out.
> 
> Best regards,
> Guillaume
> ------------------------------------------------------------------------
> Check the FAQ before asking! - http://www.openh323.org/~openh323/fom.cgi
> The OpenH323 Project mailing list, using Mailman. To unsubscribe or
> change your subscription options, goto
> http://www.openh323.org/mailman/listinfo/openh323
> Maintained by Quicknet Technologies, Inc - http://www.quicknet.net
> ------------------------------------------------------------------------
-- 
 _      Damien Sandras
(o-     
//\     GnomeMeeting: http://www.gnomemeeting.org/
v_/_    FOSDEM 2006 : http://www.fosdem.org
        SIP Phone   : sip:dsandras (at) gnomemeeting.net 
                      sip:600000 (at) gnomemeeting.net

------------------------------------------------------------------------
Check the FAQ before asking! - http://www.openh323.org/~openh323/fom.cgi
The OpenH323 Project mailing list, using Mailman. To unsubscribe or
change your subscription options, goto
http://www.openh323.org/mailman/listinfo/openh323
Maintained by Quicknet Technologies, Inc - http://www.quicknet.net
------------------------------------------------------------------------