[OPAL] Bug in SIPConnection::OnReceivedSDPMediaDescription

[Damien Sandras <dsandras (at) seconix.com>]

Le vendredi 03 février 2006 à 14:24 +0100, Guillaume Fraysse a écrit :
> Hello Damien,
> 
> Well I found the code of SIPConnection::OnUseRTPSession suspicious
> It does the following :
> RTP_UDP *rtpSession = NULL;
> ....
> if (ownerCall.IsMediaBypassPossible(*this, rtpSessionId))
> {... }
> else
> { ... }
> return rtpSession;
> 
> Which means that if media bypass is enabled the call get rejected as
> the rtpSession returned will be NULL. Didn't sound good to me.
> 
> The way I understand it, there should be some kind of way to return
> from OnUseRTPSession that doesn't reject the call if if we don't need
> RTP.
> But maybe there's a better way to do it if we don't use RTP...
> 

You are right. I will revert that patch this week-end.

Actually, if we do not release teh session, the call will fail at a
later stage, but not with TransportFail as error. I think there is no
way to do it better and the patch can be reverted.


-- 
 _      Damien Sandras
(o-     
//\     GnomeMeeting: http://www.gnomemeeting.org/
v_/_    FOSDEM 2006 : http://www.fosdem.org
        SIP Phone   : sip:dsandras (at) gnomemeeting.net 
                      sip:600000 (at) gnomemeeting.net

------------------------------------------------------------------------
Check the FAQ before asking! - http://www.openh323.org/~openh323/fom.cgi
The OpenH323 Project mailing list, using Mailman. To unsubscribe or
change your subscription options, goto
http://www.openh323.org/mailman/listinfo/openh323
Maintained by Quicknet Technologies, Inc - http://www.quicknet.net
------------------------------------------------------------------------