By Date: <-- -->
By Thread: <-- -->

: CX88 FM mute, Aver Studio 303 gpio's

Marcin,

	Next time, please send one patch by email. It is easier to handle and
allows being applied by mailimport script.

Em Sáb, 2006-02-25 às 21:51 +0100, Marcin Rudowski escreveu:
> Hello,
> 
>  ====== Aver Studio 303 ======
> 
> First of all, I would like to ask anybody to correct gpio values for
> Aver 303 Studio in v4l-dvb tree. I've already send this patch, but will
> repeat(this time with signature).
> 
> Old values generally works in A2 mono, but new ones (from regspy) allows:
> - detect and use Nicam stereo
> - mute in tv
> - use radio FM
> - ...
> 
> Here is my sign:
>    Signed-off-by: Marcin Rudowski <mar_rud (at) poczta.onet.pl>

Applied, thanks.
> 
> 
>  ====== Mute / Unmute ======
> 
> Second patch is for troubles with mute in FM mentioned in thread started
> by Mariusz Drozdziel. It should be general enough to work in all cx88
> cards with FM, but I could test it only in my case.
> 
> I checked attached patch with latest v4l-dvb from hg. This is what it gives:
> - mute/unmute in FM mode works (tested with radio, gnomeradio, v4lctl)
> - sound in FM mode is not muted by default on /dev/radioX close (option
> mute on exit in radio/gnomeradio now works as expected)
> 
> Here is my sign:
>    Signed-off-by: Marcin Rudowski <mar_rud (at) poczta.onet.pl>
> 
> 
> If You prefer actual behavior: No radio application => no sound,
> then remove added 'if' in video_release(..) function, but proposed
> solution enables functionality of 'gnomeradio' and 'radio' applications,
> which allows to choose to exit with or without mute on exit.
> Besides 'radio' allows controlling fm using command line, i.e.:
>    radio -q -f 94.0
> and with current v4l code it does work (no sound).
> Also 'kradio' by default does mute on exit (using ioctl, which is
> working with this patch), so it doesn't break this app.
> If there exist radio application that doesn't allow mute on exit, then
> i.e. v4lctl can be used.
Hmmm... This is a good point: what is better, to allow exiting with audio on or not.
I didn't apply this patch yet. I think it deserves more discussion. IMHO, it is better to mute at application close.

Cheers, 
Mauro.

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request (at) redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list