By Date: <-- -->
By Thread: <-- -->

: CX88 FM mute, Aver Studio 303 gpio's

Dnia 2006-03-09 20:13, Uzytkownik Mauro Carvalho Chehab napisal:
> Marcin,
> 
> 	Next time, please send one patch by email. It is easier to handle and
> allows being applied by mailimport script.


Thanks for notice, I will.




>> If You prefer actual behavior: No radio application => no sound,
>> then remove added 'if' in video_release(..) function, but proposed
>> solution enables functionality of 'gnomeradio' and 'radio' applications,
>> which allows to choose to exit with or without mute on exit.
>> Besides 'radio' allows controlling fm using command line, i.e.:
>>    radio -q -f 94.0
>> and with current v4l code it does work (no sound).
>> Also 'kradio' by default does mute on exit (using ioctl, which is
>> working with this patch), so it doesn't break this app.
>> If there exist radio application that doesn't allow mute on exit, then
>> i.e. v4lctl can be used.
> Hmmm... This is a good point: what is better, to allow exiting with audio on or not.
> I didn't apply this patch yet. I think it deserves more discussion. IMHO, it 
> is better to mute at application close.


After playing around with commandline tools (i.e. radio from xawtv)
IMHO, it is nice to have ability to don't mute at close.
As already described, I didn't find any radio application (I didn't
looked hard anyway) that couldn't mute at close on it's own (by default
or additional option).

If proposed behavior will be decided as generally unwanted, we can add
Yet Another Module Option ;)  (auto_mute?).

Regards,
Marcin Rudowski

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request (at) redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list