AverMedia 6 Eyes AVS6EYES support

[Martin Samuelsson <sam (at) home.se>]

On Tue, 28 Mar 2006 14:39:26 -0800
Andrew Morton <akpm (at) osdl.org> wrote:

> > +	if (3 == err) {
> 
> See, it just looks weird, sorry.

No, I agree, it makes various parts of the brain hurt, now that you've 
showed it. I've corrected, dare I say, all things you pointed out in 
the drivers, and a few more.

> > +#ifdef MODULE
> > +int init_module(void)
> > +#else
> > +int bt866_init(void)
> > +#endif
...
> Not sure what all this is about.  Please just do:

Well, I assume it's an arcane way of providing different initialization 
symbol names depending on whether the code is a module or compiled into 
the kernel. But if you've never seen it before, it's most likely safe to 
do away with.

> > +void ks0127_getcrop(struct ks0127 *ks, int *xstart, int *xend, int *ystart, int *yend)
> 
> Plese review entire patch, see whether any of its globally-visible symbols
> can be made static.

It could, and it could even be removed altogether, as it was never used 
in my stripped-down version of the ks0127 driver.

> Please try to fit things into an 80-col display.

I've done my best.

Well, I assume it wouldn't be of any significant value to submit another patch 
before it's V4L2-ed, so I'll spare you that one this time.

Regards,
/Sam

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request (at) redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list