Norwood PCI TV card support (non-pro) - updated patch
- From: Peter Naulls <peter (at) chocky.org>
- Date: Wed, 03 May 2006 18:24:33 -0700
In message <1146637365.1977.3.camel (at) t94>
"Nickolay V. Shmyrev" <nshmyrev (at) yandex.ru> wrote:
> Are you sure you need such a complicated way of getting keycode?
> Probably can find the easier way to get it.
Well, perhaps you could avoid one operation if you wanted to be really
pedantic. But yes, it does need to be complex - the result comes from
various bits on two GPOIs.
> You are also using keydown with immediate keyup, what will be with
> autorepeat in this case?
Not entirely satisfactory, but this is no different to what's done with
the existing polling case for many cards.
>
>
> > (at) (at) -1127,6 +1127,12 (at) (at) static int video_release(struct inode *i
> > >
> > > cx88_call_i2c_clients (dev->core, TUNER_SET_STANDBY, NULL);
> > >
> > > + /* Shut off audio */
> > > + if (dev->core->board == CX88_BOARD_NORWOOD_MICRO) {
> > > + struct cx88_core *core = dev->core;
> > > + cx_clear(MO_GP0_IO, 0x0001);
> > > + }
> > > +
> > > return 0;
> > > }
>
> This change seems rather strange, first of all, it's card-oriented,
> which is bad thing. Probably you need to use more generic code.
That's all very well, but you're lacking any suggestions. There's no
good section AFAICT, for putting card specific close operations (as
opposed to module unload.
> Second, it just switches gpio0 as I see, isn't it just a switch from
> the tuner to composite or something like that?
No, look again, it switches off precisely the bit which controls audio.
--
Peter Naulls - peter (at) chocky.org | http://www.chocky.org/
----------------------------------------------------------------------------
RISC OS Community Wiki - add your own content | http://www.riscos.info/
--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request (at) redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list