By Date: <-- -->
By Thread: <-- -->

ads tech instant tv pci fm - saa7134



Hi Ronald,

Your patch looks sane. However, you should follow the instructions on
linuxtv.org for submitting a patch.

Basically, you should generate your patch against the latest version
available at:
	http://linuxtv.org/hg/v4l-dvb
(there were several other card additions on saa7134)

Also, all patches need to be signed, as stated on:
	http://www.linuxtv.org/v4lwiki/index.php/How_to_submit_patches

It would also be better if you post your patch at v4l mailing list, at:
	<video4linux-list (at) redhat.com>

Cheers,
Mauro.

Em Dom, 2007-02-04 Ãs 14:37 +0100, Ronald DELOBEL escreveu:
> Hi,
> 
> Here is a patch to get radio working with ads tech instant tv pci fm,
> looks like this is the same as Kworld Terminator (65), so I have just
> copied the corresponding entry, tv and radio tested and working:
> 
> lspci output :
> 
> 00:0a.0 0480: 1131:7133 (rev f0)
>         Subsystem: 1421:0351
>         Flags: bus master, medium devsel, latency 32, IRQ 17
>         Memory at cffef800 (32-bit, non-prefetchable) [size=2K]
>         Capabilities: [40] Power Management version 2
> 
> --- saa7134.h.old       2007-02-04 14:06:43.268740492 +0100
> +++ saa7134.h   2007-02-04 13:19:38.524436924 +0100
>  (at)  (at)  -227,6 +227,7  (at)  (at)  struct saa7134_format {
>  #define SAA7134_BOARD_PROTEUS_2309 98
>  #define SAA7134_BOARD_AVERMEDIA_A16AR   99
>  #define SAA7134_BOARD_ASUS_EUROPA2_HYBRID 100
> +#define SAA7134_BOARD_ADS_INSTANT_TV_FM 101
> 
>  #define SAA7134_MAXBOARDS 8
>  #define SAA7134_INPUT_MAX 8
> 
> --- saa7134-cards.c.old 2007-01-14 12:59:28.828390842 +0100
> +++ saa7134-cards.c     2007-02-04 13:05:28.194888971 +0100
>  (at)  (at)  -1874,6 +1874,40  (at)  (at)  struct saa7134_board saa7134_boards[] =
>                         .amux = LINE2,
>                 }},
>         },
> +       [SAA7134_BOARD_ADS_INSTANT_TV_FM] = {
> +               /* Works with card=65 modprobe option */
> +               /* Kworld V-Stream Studio TV Terminator */
> +               /* "James Webb <jrwebb (at) qwest.net> */
> +               .name           = "ADS Tech Instant TV FM (saa7135)",
> +               .audio_clock    = 0x00187de7,
> +               .tuner_type     = TUNER_PHILIPS_TDA8290,
> +               .radio_type     = UNSET,
> +               .tuner_addr     = ADDR_UNSET,
> +               .radio_addr     = ADDR_UNSET,
> +               .gpiomask       = 1 << 21,
> +               .inputs         = {{
> +                       .name = name_tv,
> +                       .vmux = 1,
> +                       .amux = TV,
> +                       .gpio = 0x0000000,
> +                       .tv   = 1,
> +               },{
> +                       .name = name_comp1,     /* Composite input */
> +                       .vmux = 3,
> +                       .amux = LINE2,
> +                       .gpio = 0x0000000,
> +               },{
> +                       .name = name_svideo,    /* S-Video input */
> +                       .vmux = 8,
> +                       .amux = LINE2,
> +                       .gpio = 0x0000000,
> +               }},
> +               .radio = {
> +                       .name = name_radio,
> +                       .amux = TV,
> +                       .gpio = 0x0200000,
> +               },
> +       },
>         [SAA7134_BOARD_KWORLD_VSTREAM_XPERT] = {
>                 .name           = "Kworld/Tevion V-Stream Xpert TV
> PVR7134", .audio_clock    = 0x00187de7,
>  (at)  (at)  -3380,8 +3414,8  (at)  (at)  struct pci_device_id saa7134_pci_tbl[] =
>                 .vendor       = PCI_VENDOR_ID_PHILIPS,
>                 .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
>                 .subvendor    = 0x1421,
> -               .subdevice    = 0x0351,         /* PCI version, new
> revision */
> -               .driver_data  = SAA7134_BOARD_ADS_INSTANT_TV,
> +               .subdevice    = 0x0351,         /* PCI version with fm
> */
> +               .driver_data  = SAA7134_BOARD_ADS_INSTANT_TV_FM,
>         },{
>                 .vendor       = PCI_VENDOR_ID_PHILIPS,
>                 .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
> 
> 
> 
-- 
Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request (at) redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list