Asus MyCinema-P7131 remote fix

[Hartmut Hackmann <hartmut.hackmann (at) t-online.de>]

Hi

hermann pitton schrieb:
> Hi,
> 
> Am Montag, den 26.02.2007, 23:23 +0100 schrieb Hartmut Hackmann:
>> Hi,
>>
>> hermann pitton schrieb:
>>> Hi Boris,
>>>
>>> Am Montag, den 26.02.2007, 14:21 +0100 schrieb Boris Barbulovski:
>>>> hi, to all
>>>>
>>>> according to http://www.kernel.org/git/?
>>>> p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9160723ed620f31bf38332dee02041b1cb4c9967
>>>>
>>>> or
>>>> -----------------------------------------------
>>>> V4L/DVB (4961): Add support for the ASUS P7131 remote control
>>>>
>>>> Besides adding the board specific code, this patch moves
>>>> the RC5 decoding code from bt8xx to ir-functions.c to make it
>>>> available
>>>> for all drivers.
>>>> -----------------------------------------------
>>>>
>>>> an ASUS P7131 remote control should be enabled, but it not because it
>>>> is only enabled for ASUS P7131Dual.
>>>> There is an patch attached with this message so please check it out
>>>> and update the kernel source.
>>>>
>>>> thanks.
>>> thanks for looking at it.
>>>
>>> Unfortunately there is a problem with your card.
>>>
>>> It shares the 1043:4845 subsystem with the Asus TVFM7135 card=53,
>>> but is in fact a different card.
>>>
>>> Try the composite and s-video input, won't work.
>>> The older Asus cards also have USB connected remotes.
>>>
>>> Last time we discussed it up to this point.
>>> http://marc.theaimsgroup.com/?l=linux-video&m=114540051206996&w=2
>>>
>>> Hartmut, as always, also has to made a decision if your card without DVB
>>> should use the P7131 Dual card=78 entry.
> 
>> I still have the idea to write a parser for the eeprom, but i currently
>> don't have the time. So we might need to do something similar to what i
>> did for some other cards before.
>> Are you able to work this out and send me patch?
> 
> Don't have the board, but with Boris' help we might get something.
> Should we not better create a separate entry for the card?
> 
> The attached test stuff might be sufficient already,
> or Boris has at least the direction.
> 
> Cheers,
> Hermann
> 
> 
> 
> 
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> diff -r 8f06fcd355da linux/drivers/media/video/saa7134/saa7134-cards.c
> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c	Tue Feb 27 14:55:37 2007
> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c	Tue Feb 27 21:49:29 2007
>  (at)  (at)  -4433,6 +4433,13  (at)  (at) 
>  		i2c_transfer(&dev->i2c_adap, &msg, 1);
>  		}
>  		break;
> +	case SAA7134_BOARD_ASUSTeK_TVFM7135:
> +		if(dev->autodetected && (dev->eedata[0x27] == 0x04)) {
> +			dev->board = SAA7134_BOARD_ASUSTeK_P7131_DUAL;
> +			printk(KERN_INFO "%s: P7131 analog only using entry of %s\n",
> +			dev->name, saa7134_boards[dev->board].name);
> +		}
> +		break;
>  	case SAA7134_BOARD_PINNACLE_PCTV_310i:
>  	case SAA7134_BOARD_TEVION_DVBT_220RF:
>  	case SAA7134_BOARD_ASUSTeK_P7131_DUAL:

I would prefer a separate entry for the card and probing code similar to what you
already have.
You can take the code for Compro Videomate 200 / 200a and Philips Tiger / Tiger-S
as examples. May I ask you to send me a new patch and a eeprom dump?

I will the finetune and integrate it.

Best regards
   Hartmut

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request (at) redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list